Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use iconData and iconMediatype attributes for icon #1845

Merged
merged 1 commit into from
May 28, 2024
Merged

Use iconData and iconMediatype attributes for icon #1845

merged 1 commit into from
May 28, 2024

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented May 28, 2024

What does this PR do?

Use iconData and iconMediatype attributes for icon

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#22932

How to test this PR?

  1. Prepare a patch file if needed:
cat > /tmp/cr-patch.yaml <<EOF
apiVersion: org.eclipse.che/v2
kind: CheCluster
spec: {}
EOF
  1. Deploy the operator:

OpenShift

./build/scripts/olm/test-catalog-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

on Minikube

./build/scripts/minikube-tests/test-operator-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@tolusha tolusha requested review from SDawley and ibuziuk as code owners May 28, 2024 11:35
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 28, 2024 •
edited
Loading

@tolusha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-che-behind-proxy 21f70ce link true /test v14-che-behind-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tolusha
Copy link
Contributor Author

tolusha commented May 28, 2024

/test v14-devworkspace-happy-path

@tolusha tolusha merged commit 84673c8 into main May 28, 2024
20 of 21 checks passed
@tolusha tolusha deleted the 22932_4 branch May 28, 2024 13:59
@devstudio-release
Copy link

Build 3.15 :: operator_3.x/368: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: sync-to-downstream_3.x/6874: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6824: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: operator-bundle_3.x/3056: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: sync-to-downstream_3.x/6875: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6825: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: push-latest-container-to-quay_3.x/4662: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6824: SUCCESS

devspaces-operator : 3.x :: Build 61508573 : quay.io/devspaces/devspaces-rhel8-operator:3.15-2
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/4662 triggered

@devstudio-release
Copy link

Build 3.15 :: operator_3.x/368: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/6874 triggered

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6825: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 61510100 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.15 :: update-digests_3.x/6686: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: operator-bundle_3.x/3057: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: sync-to-downstream_3.x/6876: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6826: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6826: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 61512798 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.15 :: operator-bundle_3.x/3058: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: sync-to-downstream_3.x/6877: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6827: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6827: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 61516200 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.15 :: operator-bundle_3.x/3059: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: sync-to-downstream_3.x/6879: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6829: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6871: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6871: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 61637257 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.15 :: operator-bundle_3.x/3098: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: sync-to-downstream_3.x/6927: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6872: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6872: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 61638898 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.15 :: operator-bundle_3.x/3099: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: sync-to-downstream_3.x/6928: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6873: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6873: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 61641116 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.15 :: operator-bundle_3.x/3100: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: sync-to-downstream_3.x/6929: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6874: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6874: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 61646482 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.15 :: operator-bundle_3.x/3101: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: sync-to-downstream_3.x/6930: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6875: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6875: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 61650848 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.15 :: operator-bundle_3.x/3102: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: sync-to-downstream_3.x/6931: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6876: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6876: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 61656618 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.15 :: operator-bundle_3.x/3103: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: sync-to-downstream_3.x/6932: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6877: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6877: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 61661796 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.15 :: operator-bundle_3.x/3104: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: sync-to-downstream_3.x/6933: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6878: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6878: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 61664042 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SDawley SDawley Awaiting requested review from SDawley SDawley is a code owner

@ibuziuk ibuziuk Awaiting requested review from ibuziuk ibuziuk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tolusha @devstudio-release